base/string_util.cc - Issue 3250002: Add an accordian effect to NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_util.cc

Issue 3250002: Add an accordian effect to NTP. (Closed)

Patch Set: Fix menu positioning when there is a scrollbar. Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/string_util.cc

diff --git a/base/string_util.cc b/base/string_util.cc

index 4dbcd7b0c3bbd87d283791b43c8278d638d810f1..56aa39de6d3fdf2cb1bbf592303925a7f5046bf0 100644

--- a/base/string_util.cc

+++ b/base/string_util.cc

@@ -1013,7 +1013,11 @@ OutStringType DoReplaceStringPlaceholders(const FormatStringType& format_string,

++i;

DCHECK('$' == *i || '1' <= *i) << "Invalid placeholder: " << *i;

if ('$' == *i) {

- formatted.push_back('$');

+ while (i != format_string.end() && '$' == *i) {

Miranda Callahan 2010/08/30 21:17:15 nice. :-)

+ formatted.push_back('$');

+ ++i;

+ }

+ --i;

} else {

uintptr_t index = *i - '1';

if (offsets) {