Issue 3249009: Always treat invalid images as nonexistant now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3249009: Always treat invalid images as nonexistant now. (Closed)

Created:
10 years, 3 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Always treat invalid images as nonexistant now. This makes the sequence of pictures shown to the user slightly less confusing, but the whole process needs a bit more cleanup. Some of the work has to be done in the BIOS code, not just here. This is better, but it's not complete. Change-Id: If0b3ecc92716020a06031866849d83411d7f0db8 BUG=chrome-os-partner:903 TEST=manual

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	firmware/lib/vboot_kernel.c	View		1 chunk	+6 lines, -5 lines	0 comments	Download
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

10 years, 3 months ago (2010-08-30 22:14:25 UTC) #2

Well, it's more "treat any device which doesn't have a good kernel as invalid"
than "as nonexistant", but I agree with the change.

LGTM.

Expand Messages | Collapse Messages