Copying .subversion directory into the chroot,

Copying .subversion directory into the chroot,
so that the original users' subversion access permissions are preserved inside the chroot

Change-Id: I486070b3c1a2dda169ae0a95982ba693574e001b

BUG=
TEST=

[Mandeep Singh Baines, 2010-08-30 22:32:40]

LGTM

aluri@chromium.org (aluri@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, sosa,
> 
> Description:
> Copying .subversion directory into the chroot,
> so that the original users' subversion access permissions are
> preserved inside
> the chroot
> 
> Change-Id: I486070b3c1a2dda169ae0a95982ba693574e001b
> 
> BUG=
> TEST=
> 
> Please review this at http://codereview.chromium.org/3249008/show
> 
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
> 
> Affected files:
>   M enter_chroot.sh
> 
> 
> Index: enter_chroot.sh
> diff --git a/enter_chroot.sh b/enter_chroot.sh
> index
f8dcd1d2df7ea50eb1b3c28b40f759f54a1451ca..ae5adf863481b027375e13e84b698e5a58071e00
> 100755
> --- a/enter_chroot.sh
> +++ b/enter_chroot.sh
> @@ -259,6 +259,11 @@ setup_env
>  # Use git:8 chars of sha1
>  REVISION=$(git rev-parse --short=8 HEAD)
>  CHROOT_PASSTHRU="CHROMEOS_REVISION=$REVISION
> BUILDBOT_BUILD=$FLAGS_build_number
> CHROMEOS_OFFICIAL=$CHROMEOS_OFFICIAL"
> +if [[ -d $HOME/.subversion ]]; then
> +  # Copy .subversion into chroot so subversion access permissions
> of the user are preserved.
> +  echo "Copying ~/.subversion into chroot"
> +  cp -rf $HOME/.subversion "$FLAGS_chroot/home/$USER/"
> +fi
> 
>  # Run command or interactive shell.  Also include the non-chrooted path to
>  # the source trunk for scripts that may need to print it (e.g.
> 
> 

[sosa, 2010-08-30 22:37:00]

Isn't this doing the same thing?  

http://codereview.chromium.org/3277006/show

[Raja Aluri, 2010-08-31 00:18:32]

PTAL.
Copied ellyjone's code from
http://codereview.chromium.org/3277006/show
except that, I do a mkdir -p and 'die' instead of 'warn' on failure.

[sosa, 2010-08-31 00:36:35]

nits o/w lgtm

http://codereview.chromium.org/3249008/diff/5001/6001
File enter_chroot.sh (right):

http://codereview.chromium.org/3249008/diff/5001/6001#newcode266
enter_chroot.sh:266: if [ -z "$(mount | grep -F "on $MOUNTED_PATH ")" ]
"; then" rather than waste a new line / tab

http://codereview.chromium.org/3249008/diff/5001/6001#newcode269
enter_chroot.sh:269: sudo mount --bind $HOME/.subversion "$MOUNTED_PATH" || \
quotes around var

[davidjames, 2010-08-31 01:06:54]

http://codereview.chromium.org/3249008/diff/5001/6001
File enter_chroot.sh (right):

http://codereview.chromium.org/3249008/diff/5001/6001#newcode262
enter_chroot.sh:262: if [[ -d "$HOME/.subversion" ]]; then
[[ is a bashism. Better to use single [ which works in dash.

http://codereview.chromium.org/3249008/diff/5001/6001#newcode268
enter_chroot.sh:268: mkdir -p "${FLAGS_chroot}/home/${USER}/.subversion"
Couldn't this just be mkdir -p "$MOUNTED_PATH" ?

[Raja Aluri, 2010-08-31 01:40:36]

http://codereview.chromium.org/3249008/diff/5001/6001
File enter_chroot.sh (right):

http://codereview.chromium.org/3249008/diff/5001/6001#newcode262
enter_chroot.sh:262: if [[ -d "$HOME/.subversion" ]]; then
On 2010/08/31 01:06:54, davidjames wrote:
> [[ is a bashism. Better to use single [ which works in dash.

Done.

http://codereview.chromium.org/3249008/diff/5001/6001#newcode266
enter_chroot.sh:266: if [ -z "$(mount | grep -F "on $MOUNTED_PATH ")" ]
On 2010/08/31 00:36:35, sosa wrote:
> "; then" rather than waste a new line / tab

Done.

http://codereview.chromium.org/3249008/diff/5001/6001#newcode268
enter_chroot.sh:268: mkdir -p "${FLAGS_chroot}/home/${USER}/.subversion"
On 2010/08/31 01:06:54, davidjames wrote:
> Couldn't this just be mkdir -p "$MOUNTED_PATH" ?

Done.

http://codereview.chromium.org/3249008/diff/5001/6001#newcode269
enter_chroot.sh:269: sudo mount --bind $HOME/.subversion "$MOUNTED_PATH" || \
On 2010/08/31 00:36:35, sosa wrote:
> quotes around var

Done.