Issue 3248003: Allow src_test to require running src_configure step first

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3248003: Allow src_test to require running src_configure step first (Closed)

Created:
10 years, 3 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Allow src_test to require running src_configure step first TEST=ran the script on all tests successfully Change-Id: I992b9ed2ce99fc30aa542bf6c953d04ffe1d62d0

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_run_unit_tests	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 3 months ago (2010-08-27 19:56:12 UTC) #2

LGTM~

On Fri, Aug 27, 2010 at 12:40 PM,  <kmixter@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> Allow src_test to require running src_configure step first
>
> TEST=ran the script on all tests successfully
>
> Change-Id: I992b9ed2ce99fc30aa542bf6c953d04ffe1d62d0
>
> Please review this at http://codereview.chromium.org/3248003/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M cros_run_unit_tests
>
>
> Index: cros_run_unit_tests
> diff --git a/cros_run_unit_tests b/cros_run_unit_tests
> index
>
0d85b7623ccacf1e829d6a5a8395717be5caf53b..9a17b4452df63f49df68c12b5eec9430a3419e81
> 100755
> --- a/cros_run_unit_tests
> +++ b/cros_run_unit_tests
> @@ -42,7 +42,7 @@ function record_test_failure() {
>
>  function run_unit_test() {
>   FEATURES="-buildpkg -digest noauto" \
> -    ebuild-${FLAGS_board} "${1}" clean unpack test
> +    ebuild-${FLAGS_board} "${1}" clean unpack configure test
>  }
>
>  # Parse command line and die if unexpected paramters given.
>
>
>

Expand Messages | Collapse Messages