Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 3240007: Fix keyword table access in the same way credit_card table was just fixed. Th... (Closed)

Created:
10 years, 3 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fix web_database credit card table data migration. (This is the trunk version of 3228011). BUG=10913 TEST= run build on profile from before 37036; search engines should work. run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58105

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M chrome/browser/webdata/web_database.h View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 2 3 4 5 6 chunks +50 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Miranda Callahan
Not sure this is necessary, but that probably means it should go in, just to ...
10 years, 3 months ago (2010-08-30 23:54:57 UTC) #1
sky
LGTM
10 years, 3 months ago (2010-08-31 00:06:23 UTC) #2
sky
10 years, 3 months ago (2010-08-31 00:06:39 UTC) #3
And a test case here would be great as well.

Powered by Google App Engine
This is Rietveld 408576698