Issue 3239005: Remove the default argument from RegKey::WriteValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3239005: Remove the default argument from RegKey::WriteValue. (Closed)

Created:
10 years, 3 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Remove the default argument from RegKey::WriteValue. BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57777

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/registry.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/3239005/diff/1/2 File base/registry.h (right): http://codereview.chromium.org/3239005/diff/1/2#newcode60 base/registry.h:60: DWORD* dtype = NULL); so this is the ...

10 years, 3 months ago (2010-08-28 02:07:17 UTC) #2

tfarina

10 years, 3 months ago (2010-08-28 03:16:29 UTC) #3

On 2010/08/28 02:07:17, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://codereview.chromium.org/3239005/diff/1/2
> File base/registry.h (right):
> 
> http://codereview.chromium.org/3239005/diff/1/2#newcode60
> base/registry.h:60: DWORD* dtype = NULL);
> so this is the only one remaining?
Yup! Finally :)

Expand Messages | Collapse Messages