Issue 3239001: use JEDEC_SE as the default sector erase opcode for ICH southbridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3239001: use JEDEC_SE as the default sector erase opcode for ICH southbridge (Closed)

Created:
10 years, 4 months ago by dhendrix

Modified:
9 years, 5 months ago

Reviewers:
Louis

Base URL:
ssh://git@gitrw.chromium.org/flashrom

Visibility:
Public.

Description

use JEDEC_SE as the default sector erase opcode for ICH southbridge Note: We should definitely look into on-the-fly opcode reprogramming as the comment in ich_spi_send_multicommand() suggests.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ichspi.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Louis

LGTM. Can we associate this CL to the issue tracker? http://code.google.com/p/chromium-os/issues/detail?id=6152

10 years, 4 months ago (2010-08-27 04:09:28 UTC) #2

dhendrix

10 years, 4 months ago (2010-08-27 04:27:13 UTC) #3

On 2010/08/27 04:09:28, Louis wrote:
> LGTM. Can we associate this CL to the issue tracker? 
> http://code.google.com/p/chromium-os/issues/detail?id=6152

Hmmm, I don't think we can associate issues with tracker :-( I'll just add a
comment to the tracker issue to point to this CL.

Expand Messages | Collapse Messages