Issue 3238012: Change clobber logic to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3238012: Change clobber logic to be explicit (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Change clobber logic to be explicit TEST=Tested with --clobber and without. Change-Id: I6a938b3da673d97186cec79f25b22ea6176f1fdf

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	bin/cbuildbot.py	View	1	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

Change semantics so we can explicitly call clobber from buildbot.

10 years, 3 months ago (2010-08-30 16:56:24 UTC) #1

petkov

10 years, 3 months ago (2010-08-30 17:30:02 UTC) #2

one comment, LGTM otherwise.

http://codereview.chromium.org/3238012/diff/1/2
File bin/cbuildbot.py (right):

http://codereview.chromium.org/3238012/diff/1/2#newcode381
bin/cbuildbot.py:381: help='Disables clobbering the buildroot on failure')
Fix description.

Expand Messages | Collapse Messages