Issue 3236001: Add the collapsed 'miniview' to the apps and most visisted sections.

Issue 3236001: Add the collapsed 'miniview' to the apps and most visisted sections. (Closed)

Created:
10 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews), Miranda Callahan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Add the collapsed 'miniview' to the apps and most visisted sections. Also, fix the bug where the wrench disappears on hover. BUG=53248, 52199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57799

Patch Set 1 #

Patch Set 2 : cleanup unnecessary changes #

Patch Set 3 : more unnecessary changes #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -36 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/app_launcher_handler.cc	View		2 chunks	+22 lines, -11 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_favicon_source.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_favicon_source.cc	View		2 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View		4 chunks	+10 lines, -6 lines	1 comment	Download
M	chrome/browser/resources/new_new_tab.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View		2 chunks	+9 lines, -3 lines	1 comment	Download
M	chrome/browser/resources/new_tab_theme.css	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/ntp/apps.css	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	1 2	5 chunks	+23 lines, -3 lines	2 comments	Download
M	chrome/browser/resources/ntp/most_visited.js	View		3 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

Looks good to me. For my part, I'm coming along with the context menu; the ...

10 years, 4 months ago (2010-08-27 05:13:05 UTC) #2

arv (Not doing code reviews)

10 years, 3 months ago (2010-08-31 20:54:21 UTC) #3

FYI

http://codereview.chromium.org/3236001/diff/4001/5008
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/3236001/diff/4001/5008#newcode373
chrome/browser/resources/new_new_tab.css:373: margin-left:-10px;
-webkit-margin-start: -10px;
-webkit-margin-end: -10px;

http://codereview.chromium.org/3236001/diff/4001/5010
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/3236001/diff/4001/5010#newcode881
chrome/browser/resources/new_new_tab.js:881:
$('most-visited-section').getElementsByClassName('miniview')[0],
document.querySelector('#most-visited-section .miniview')

http://codereview.chromium.org/3236001/diff/4001/5013
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/3236001/diff/4001/5013#newcode9
chrome/browser/resources/ntp/apps.js:9: var appsMiniview =
appsSection.getElementsByClassName('miniview')[0];
I find querySelector to be easier to use

http://codereview.chromium.org/3236001/diff/4001/5013#newcode50
chrome/browser/resources/ntp/apps.js:50: chrome.send('launchApp',
[this.getAttribute("app_id"), launchType,
single quotes

Expand Messages | Collapse Messages