Issue 3235010: reland r57885 with a fix for linux/views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3235010: reland r57885 with a fix for linux/views. (Closed)

Created:
10 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

reland r57885 with a fix for linux/views. [GTK] a couple of constrained window fixes: 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58259

Patch Set 1 #

Patch Set 2 : . #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -111 lines)			Patch
M	chrome/browser/gtk/constrained_window_gtk.h	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/gtk/constrained_window_gtk.cc	View	4 chunks	+15 lines, -36 lines	0 comments	Download
M	chrome/browser/gtk/focus_store_gtk.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/focus_store_gtk.cc	View	2 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/gtk/gtk_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_util.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/login_prompt_gtk.cc	View	5 chunks	+45 lines, -31 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	5 chunks	+38 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Please watch the tree after landing.

Expand Messages | Collapse Messages