Issue 3234004: [autotest] Fix chrome log collection

Issue 3234004: [autotest] Fix chrome log collection (Closed)

Created:
10 years, 3 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

[autotest] Fix chrome log collection BUG=None TEST=run desktopui_ChromeFirstRender (do "TESTS=desktopui_ChromeFirstRender emerge-x86-generic autotest autotest-tests" first, or you won't pick up the changes to site_ui_test.py!) Change-Id: Icb366bbac87868eda3b14928058f1c4c8a631585

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	client/bin/chromeos_constants.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	client/bin/site_ui_test.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 3 months ago (2010-08-28 00:36:52 UTC) #2

LGTM

On Fri, Aug 27, 2010 at 5:28 PM,  <cmasone@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> [autotest] Fix chrome log collection
>
> BUG=None
> TEST=run desktopui_ChromeFirstRender (do "TESTS=desktopui_ChromeFirstRender
> emerge-x86-generic autotest autotest-tests" first, or you won't pick up the
> changes to site_ui_test.py!)
>
> Change-Id: Icb366bbac87868eda3b14928058f1c4c8a631585
>
> Please review this at http://codereview.chromium.org/3234004/show
>
> SVN Base: http://git.chromium.org/git/autotest.git
>
> Affected files:
>  M client/bin/chromeos_constants.py
>  M client/bin/site_ui_test.py
>
>
> Index: client/bin/chromeos_constants.py
> diff --git a/client/bin/chromeos_constants.py
> b/client/bin/chromeos_constants.py
> index
>
d973ad1943a962db4c0193b003118d8152c391a6..4e6cef8086baa99801c348764110a5d5a7b418c4
> 100644
> --- a/client/bin/chromeos_constants.py
> +++ b/client/bin/chromeos_constants.py
> @@ -4,6 +4,7 @@
>
>  # The names of expected mount-points, devices, magic files, etc on chrome
> os.
>
> +CHROME_LOG_DIR = '/var/log/chrome'
>  USER_DATA_DIR = '/home/chronos'
>
>  LOGIN_PROFILE = USER_DATA_DIR+'/Default'
> Index: client/bin/site_ui_test.py
> diff --git a/client/bin/site_ui_test.py b/client/bin/site_ui_test.py
> index
>
a101d9ff85976d0856b8a88b0f0f927ae70d79c7..83c156ae2b5fc0634b1fcabd8d62c088f16101b3
> 100644
> --- a/client/bin/site_ui_test.py
> +++ b/client/bin/site_ui_test.py
> @@ -240,14 +240,14 @@ class UITest(bin_test.test):
>         """Overridden from test.cleanup() to log out when the test is
> complete.
>         """
>         try:
> -            shutil.copy(chromeos_constants.USER_DATA_DIR+'/chrome_log',
> +            shutil.copy(chromeos_constants.CHROME_LOG_DIR+'/chrome',
>                         self.resultsdir+'/chrome_prelogin_log')
>         except (IOError, OSError) as error:
>             logging.error(error)
>
>         if site_login.logged_in():
>             try:
> -
>  shutil.copy(chromeos_constants.USER_DATA_DIR+'/user/chrome_log',
> +
>  shutil.copy(chromeos_constants.CRYPTOHOME_MOUNT_PT+'/chrome',
>                             self.resultsdir+'/chrome_postlogin_log')
>             except (IOError, OSError) as error:
>                 logging.error(error)
>
>
>

Expand Messages | Collapse Messages