Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 3233004: remove TimeToDrop support (Closed)

Created:
10 years, 3 months ago by Sam Leffler
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa
Base URL:
ssh://git@chromiumos-git//metrics.git
Visibility:
Public.

Description

remove TimeToDrop support Now that flimflam has native support this can be purged. TEST=run FEATURES=test emerge-x86-generic metrics; verify TimeToDrop is still being recorded w/ about:histograms/Network

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -225 lines) Patch
M metrics_daemon.h View 6 chunks +0 lines, -27 lines 0 comments Download
M metrics_daemon.cc View 8 chunks +1 line, -118 lines 0 comments Download
M metrics_daemon_test.cc View 6 chunks +0 lines, -80 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Leffler
Will be committed together w/ flimflam crosmetrics CL.
10 years, 3 months ago (2010-08-30 00:40:56 UTC) #1
petkov
10 years, 3 months ago (2010-08-30 05:10:12 UTC) #2
Can you also remove network_states.h?

LGTM otherwise.

Powered by Google App Engine
This is Rietveld 408576698