Issue 3233004: remove TimeToDrop support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3233004: remove TimeToDrop support (Closed)

Created:
10 years, 3 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git//metrics.git

Visibility:
Public.

Description

remove TimeToDrop support Now that flimflam has native support this can be purged. TEST=run FEATURES=test emerge-x86-generic metrics; verify TimeToDrop is still being recorded w/ about:histograms/Network

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -225 lines)			Patch
M	metrics_daemon.h	View	6 chunks	+0 lines, -27 lines	0 comments	Download
M	metrics_daemon.cc	View	8 chunks	+1 line, -118 lines	0 comments	Download
M	metrics_daemon_test.cc	View	6 chunks	+0 lines, -80 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

Will be committed together w/ flimflam crosmetrics CL.

10 years, 3 months ago (2010-08-30 00:40:56 UTC) #1

Can you also remove network_states.h?

LGTM otherwise.

Expand Messages | Collapse Messages