Issue 3231007: Add 9999 revving logic to cros_mark_all_as_stable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3231007: Add 9999 revving logic to cros_mark_all_as_stable. (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add 9999 revving logic to cros_mark_all_as_stable. TEST=Ran it and saw appropriate changes. Change-Id: I5f51e16918993b9dbf53b38cb3a365fafe77c8eb

Patch Set 1 #

Patch Set 2 : ws #

Total comments: 1

Patch Set 3 : Fix egrep command #

Patch Set 4 : Fix comment #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	cros_mark_all_as_stable	View	1 2 3	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

10 years, 3 months ago (2010-08-30 18:27:57 UTC) #2

LGTM but suggested possible alternative to consider.

http://codereview.chromium.org/3231007/diff/2001/3001
File cros_mark_all_as_stable (right):

http://codereview.chromium.org/3231007/diff/2001/3001#newcode86
cros_mark_all_as_stable:86: grep -c [KEYWORDS,CROS_WORKON_COMMIT]) -ne 3 ]; then
This seems a little fragile. What if instead you tested whether, or not,
converting the 9999 ebuild to stable resulted in a diff? iow, would this 9999
ebuild have generated the current stable.

Expand Messages | Collapse Messages