Fix remaining localhost resolution issues.

net/base/host_resolver_proc.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/host_resolver_proc.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 #include <resolv.h>
 #endif
 
 #include "base/logging.h"
 #include "net/base/address_list.h"
 #include "net/base/dns_reload_timer.h"
 #include "net/base/net_errors.h"
 #include "net/base/sys_addrinfo.h"
 
 namespace net {
 
+namespace {
+
+bool IsAllLocalhostOfOneFamily(const struct addrinfo* ai) {
+  bool saw_v4_localhost = false;
+  bool saw_v6_localhost = false;
+  for (; ai != NULL; ai = ai->ai_next) {
+    switch (ai->ai_family) {
+      case AF_INET: {
+        const struct sockaddr_in* addr_in =
+            reinterpret_cast<struct sockaddr_in*>(ai->ai_addr);
+        if ((ntohl(addr_in->sin_addr.s_addr) & 0xff000000) == 0x7f000000)
+          saw_v4_localhost = true;
+        else
+          return false;
+        break;
+      }
+      case AF_INET6: {
+        const struct sockaddr_in6* addr_in6 =
+            reinterpret_cast<struct sockaddr_in6*>(ai->ai_addr);
+        if (IN6_IS_ADDR_LOOPBACK(&addr_in6->sin6_addr))
+          saw_v6_localhost = true;
+        else
+          return false;
+        break;
+      }
+      default:
+        NOTREACHED();
+        return false;
+    }
+  }
+
+  return saw_v4_localhost != saw_v6_localhost;
+}
+
+}  // namespace
+
 HostResolverProc* HostResolverProc::default_proc_ = NULL;
 
 HostResolverProc::HostResolverProc(HostResolverProc* previous) {
   SetPreviousProc(previous);
 
   // Implicitly fall-back to the global default procedure.
   if (!previous)
     SetPreviousProc(default_proc_);
 }
 
@@ skipping 123 matching lines @@
   if (host_resolver_flags & HOST_RESOLVER_LOOPBACK_ONLY)
     hints.ai_flags &= ~AI_ADDRCONFIG;
 
   if (host_resolver_flags & HOST_RESOLVER_CANONNAME)
     hints.ai_flags |= AI_CANONNAME;
 
   // Restrict result set to only this socket type to avoid duplicates.
   hints.ai_socktype = SOCK_STREAM;
 
   int err = getaddrinfo(host.c_str(), NULL, &hints, &ai);
+  bool should_retry = false;
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_OPENBSD)
   // If we fail, re-initialise the resolver just in case there have been any
   // changes to /etc/resolv.conf and retry. See http://crbug.com/11380 for info.
   if (err && DnsReloadTimerHasExpired()) {
     res_nclose(&_res);
     if (!res_ninit(&_res))
-      err = getaddrinfo(host.c_str(), NULL, &hints, &ai);
+      should_retry = true;
   }
 #endif
+  // If the lookup was restricted (either by address family, or address
+  // detection), and the results where all localhost of a single family,
+  // maybe we should retry.  There were several bugs related to these
+  // issues, for example http://crbug.com/42058 and http://crbug.com/49024
+  if ((hints.ai_family != AF_UNSPEC || hints.ai_flags & AI_ADDRCONFIG) &&
+      err == 0 && IsAllLocalhostOfOneFamily(ai)) {

[willchan no longer on Chromium, 2010/09/03 19:36:50]

I personally think "err == OK" is more readable, but I defer to you.

[vandebo (ex-Chrome), 2010/09/03 19:42:18]

err is the result of getaddrinfo, not a chrome network function.  While OK is 0,
it could be something else.  I think == 0 is the right thing, though maybe a bit
pedantic.

[willchan no longer on Chromium, 2010/09/03 20:23:07]

Oops, sorry, I thought this was a net::Error.  I completely agree.

+    if (host_resolver_flags & HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6) {
+      hints.ai_family = AF_UNSPEC;
+      should_retry = true;
+    }
+    if (hints.ai_flags & AI_ADDRCONFIG) {
+      hints.ai_flags &= ~AI_ADDRCONFIG;
+      should_retry = true;
+    }
+  }
+  if (should_retry) {
+    freeaddrinfo(ai);

[willchan no longer on Chromium, 2010/09/03 19:36:50]

don't you need a NULL check here?  In the line 207 condition, won't ai be NULL? 
delete does a NULL check, but I don't think free() does (I'm not sure).

[vandebo (ex-Chrome), 2010/09/03 19:42:18]

From man 3 free: 'If ptr is NULL, no operation is performed.'

[willchan no longer on Chromium, 2010/09/03 20:23:07]

Clearly I haven't done C programming in forever.

+    ai = NULL;
+    err = getaddrinfo(host.c_str(), NULL, &hints, &ai);
+  }
 
   if (err) {
     if (os_error) {
 #if defined(OS_WIN)
       *os_error = WSAGetLastError();
 #else
       *os_error = err;
 #endif
     }
     return ERR_NAME_NOT_RESOLVED;
   }
 
   addrlist->Adopt(ai);
   return OK;
 }
 
 }  // namespace net