Add physical presence initialization and locking to one-time initializations.

Add physical presence initialization and locking to one-time initializations.

Change-Id: If2b6041fe93bc97885e45bbb0cf7e1b81cb06c18

BUG=none
TEST=none

[Luigi Semenzato, 2010-08-31 17:04:29]

Here we go.  I think it's little enough code to leave it in the firmware, but it
could certainly go in the installation shim---and it wouldn't be much work.

[Randall Spangler, 2010-08-31 17:34:58]

LGTM with a few nits on comments.

http://codereview.chromium.org/3229011/diff/1/2
File firmware/lib/rollback_index.c (right):

http://codereview.chromium.org/3229011/diff/1/2#newcode116
firmware/lib/rollback_index.c:116: /* Initializes the firmware and kernel spaces
*/
Usual style is to phrase as an action ('do this') rather than a description
('does this').  See for example lines 183, 194, etc.

http://codereview.chromium.org/3229011/diff/1/2#newcode177
firmware/lib/rollback_index.c:177: * presence command.
Try enabling it, then try asserting PP again.

[Luigi Semenzato, 2010-08-31 19:59:05]

PTAL

From the Google style guide:

Every function declaration should have comments immediately preceding it that
describe what the function does and how to use it. These comments should be
descriptive ("Opens the file") rather than imperative ("Open the file"); the
comment describes the function, it does not tell the function what to do.

http://codereview.chromium.org/3229011/diff/1/2
File firmware/lib/rollback_index.c (right):

http://codereview.chromium.org/3229011/diff/1/2#newcode116
firmware/lib/rollback_index.c:116: /* Initializes the firmware and kernel spaces
*/
On 2010/08/31 17:34:59, Randall Spangler wrote:
> Usual style is to phrase as an action ('do this') rather than a description
> ('does this').  See for example lines 183, 194, etc.

Hey, don't get me started on this!  That's also the style I prefer, because it
matches the language statements (return this, do that, etc.)  But it's not the
Google style!

http://codereview.chromium.org/3229011/diff/1/2#newcode177
firmware/lib/rollback_index.c:177: * presence command.
On 2010/08/31 17:34:59, Randall Spangler wrote:
> Try enabling it, then try asserting PP again.

You mean, add this to the comment.  Yes, good idea, thanks.

[Randall Spangler, 2010-08-31 20:01:37]

Approves the CL.  Disagrees with the coding style, but deals with it for now. 
Sighs and returns to work.

(LGTM).

[Luigi Semenzato, 2010-08-31 20:16:17]

Actually, upon more careful reading, it appears the third-person rule
applies only to function headers.  Which gives us a choice between
ugly and inconsistent.

On Tue, Aug 31, 2010 at 1:01 PM,  <rspangler@chromium.org> wrote:
> Approves the CL.  Disagrees with the coding style, but deals with it for
> now.
> Sighs and returns to work.
>
> (LGTM).
>
>
> http://codereview.chromium.org/3229011/show
>