Issue 3229007: Chromoting: Get screen size locally if it wasn't given in the mouse message....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3229007: Chromoting: Get screen size locally if it wasn't given in the mouse message.... (Closed)

Created:
10 years, 3 months ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, John Grabowski, dmac, pam+watch_chromium.org, awong, garykac

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chromoting: Get screen size locally if it wasn't given in the mouse message. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58002

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
M	chrome/service/service_process.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/host/event_executor.h	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	remoting/host/event_executor_linux.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/event_executor_linux.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/host/event_executor_mac.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/event_executor_mac.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/host/event_executor_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/event_executor_win.cc	View	1	3 chunks	+14 lines, -1 line	0 comments	Download
M	remoting/host/mock_objects.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

10 years, 3 months ago (2010-08-30 07:00:02 UTC) #2

LGTM after the log message is added.

http://codereview.chromium.org/3229007/diff/1/7
File remoting/host/event_executor_win.cc (right):

http://codereview.chromium.org/3229007/diff/1/7#newcode393
remoting/host/event_executor_win.cc:393: return;
Do a LOG(ERROR) here.

Expand Messages | Collapse Messages