Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 3228011: Fix web_database credit card table data migration.... (Closed)

Created:
10 years, 3 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fix web_database credit card table data migration. BUG=10913 TEST= run build on profile from before 37036; search engines should work. run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58106

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -23 lines) Patch
M chrome/browser/webdata/web_database.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 2 5 chunks +48 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Miranda Callahan
10 years, 3 months ago (2010-08-31 21:20:54 UTC) #1
sky
LGTM
10 years, 3 months ago (2010-08-31 21:25:41 UTC) #2
Scott Hess - ex-Googler
lgtm, minor caveats. Still waiting on a unit test :-). http://codereview.chromium.org/3228011/diff/4001/5001 File chrome/browser/webdata/web_database.cc (right): http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838 ...
10 years, 3 months ago (2010-08-31 21:50:14 UTC) #3
GeorgeY
LGTM
10 years, 3 months ago (2010-08-31 22:03:13 UTC) #4
Miranda Callahan
http://codereview.chromium.org/3228011/diff/4001/5001 File chrome/browser/webdata/web_database.cc (right): http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838 chrome/browser/webdata/web_database.cc:1838: // issues WILL OCCUR. (see http://crbug.com/10913)! On 2010/08/31 21:50:14, ...
10 years, 3 months ago (2010-08-31 22:22:11 UTC) #5
Scott Hess - ex-Googler
10 years, 3 months ago (2010-08-31 22:31:00 UTC) #6
lgtm.

Someone should log an M-7 pri-0 (ok, maybe 1) bug to come back through and put
the right transaction thing in there.

http://codereview.chromium.org/3228011/diff/4001/5001
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838
chrome/browser/webdata/web_database.cc:1838: // issues WILL OCCUR. (see
http://crbug.com/10913)!
On 2010/08/31 22:22:11, Miranda Callahan wrote:
> On 2010/08/31 21:50:14, shess wrote:
> > WARNING good, but I think you should also describe how the alter can fail,
in
> > which case the select needs to succeed.
> > 
> > Does case 20 have this problem?  How about case 24?
> 
> Made the warning very explicit.

+1 AWESOME!  When is the tech-talk?

Powered by Google App Engine
This is Rietveld 408576698