Fix web_database credit card table data migration....

Fix web_database credit card table data migration.

BUG=10913
TEST= run build on profile from before 37036; search engines should work.  run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58106

[sky, 2010-08-31 21:25:41]

LGTM

[Scott Hess - ex-Googler, 2010-08-31 21:50:14]

lgtm, minor caveats.  Still waiting on a unit test :-).

http://codereview.chromium.org/3228011/diff/4001/5001
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838
chrome/browser/webdata/web_database.cc:1838: // issues WILL OCCUR. (see
http://crbug.com/10913)!
WARNING good, but I think you should also describe how the alter can fail, in
which case the select needs to succeed.

Does case 20 have this problem?  How about case 24?

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1850
chrome/browser/webdata/web_database.cc:1850: "SELECT card_number_encrypted FROM
credit_cards limit 1")) {
Does the select need to include verification_code_encrypted, too?

[GeorgeY, 2010-08-31 22:03:13]

LGTM

[Miranda Callahan, 2010-08-31 22:22:11]

http://codereview.chromium.org/3228011/diff/4001/5001
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838
chrome/browser/webdata/web_database.cc:1838: // issues WILL OCCUR. (see
http://crbug.com/10913)!
On 2010/08/31 21:50:14, shess wrote:
> WARNING good, but I think you should also describe how the alter can fail, in
> which case the select needs to succeed.
> 
> Does case 20 have this problem?  How about case 24?

Made the warning very explicit.

For the case of the keywords tables, we have always had these tables from the
beginning of 1.0 Chrome, so the odd corruption case should not occur: any
badness means actual table badness.

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1850
chrome/browser/webdata/web_database.cc:1850: "SELECT card_number_encrypted FROM
credit_cards limit 1")) {
On 2010/08/31 21:50:14, shess wrote:
> Does the select need to include verification_code_encrypted, too?

Done.

[Scott Hess - ex-Googler, 2010-08-31 22:31:00]

lgtm.

Someone should log an M-7 pri-0 (ok, maybe 1) bug to come back through and put
the right transaction thing in there.

http://codereview.chromium.org/3228011/diff/4001/5001
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/3228011/diff/4001/5001#newcode1838
chrome/browser/webdata/web_database.cc:1838: // issues WILL OCCUR. (see
http://crbug.com/10913)!
On 2010/08/31 22:22:11, Miranda Callahan wrote:
> On 2010/08/31 21:50:14, shess wrote:
> > WARNING good, but I think you should also describe how the alter can fail,
in
> > which case the select needs to succeed.
> > 
> > Does case 20 have this problem?  How about case 24?
> 
> Made the warning very explicit.

+1 AWESOME!  When is the tech-talk?