Issue 3227007: Move BitmapPlatformDevice::makeOpaque into a shared file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3227007: Move BitmapPlatformDevice::makeOpaque into a shared file (Closed)

Created:
10 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Move BitmapPlatformDevice::makeOpaque into a shared file so it's implemented on all platforms. This makes the method available on Linux+Mac, while removing BitmapPlatformDevice::processPixels from Mac (doesn't appear to be used anywhere). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58274

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -124 lines)			Patch
A	skia/ext/bitmap_platform_device.cc	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_linux.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_mac.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_mac.cc	View	2 chunks	+0 lines, -49 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View	2 chunks	+0 lines, -59 lines	0 comments	Download
M	skia/ext/platform_device_mac.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	skia/skia.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages