Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 3227006: Cause cros_workon to die rather than clobber local_manifest (Closed)

Created:
10 years, 3 months ago by kliegs
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Cause cros_workon to die rather than clobber local_manifest cros_workon would clobber local edits to local_manifest in many cases This is a quick fix to prevent it. The proper solution is to actually parse local_manifest as an XML doc and modify the DOM. Not play tricks with grep. BUG=chromium-os:6272 TEST=Ran cros_workon against missing local_manifest, auto-generated local_manifest, local_manifest with indented tags. local_manifest with multi-line tags and local_manifest with <remote tags.

Patch Set 1 #

Patch Set 2 : Added a test for case issues in tags #

Patch Set 3 : Changed greps to use -q instead of redirects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M cros_workon View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kliegs
10 years, 3 months ago (2010-08-31 15:18:20 UTC) #1
Mandeep Singh Baines
LGTM. I'll try to have the XML parsing CL out withing the next couple of ...
10 years, 3 months ago (2010-08-31 17:14:16 UTC) #2
kliegs
10 years, 3 months ago (2010-08-31 17:26:40 UTC) #3
Mandeep Singh Baines
LGTM. You can use -q to avoid all the >> /dev/null's.
10 years, 3 months ago (2010-08-31 17:35:27 UTC) #4
kliegs
On 2010/08/31 17:35:27, Mandeep Singh Baines wrote: > LGTM. You can use -q to avoid ...
10 years, 3 months ago (2010-08-31 17:47:19 UTC) #5
kliegs
10 years, 3 months ago (2010-08-31 17:52:14 UTC) #6
Mandeep Singh Baines
LGTM Sorry for the delay. Was offline firefighting today.
10 years, 3 months ago (2010-09-01 03:42:53 UTC) #7
zbehan
This is probably only temporary, before mandeep finishes his change, but still good. LGTM over ...
10 years, 3 months ago (2010-09-01 03:45:15 UTC) #8
kliegs
10 years, 3 months ago (2010-09-01 14:01:58 UTC) #9
Agreed this is temporary.  Its meant to prevent data loss in the interim. 
Change checked in, with luck no one ever notices it.

On 2010/09/01 03:45:15, zbehan wrote:
> This is probably only temporary, before mandeep finishes his change, but
> still good.
> 
> LGTM over its dead core dump.
> 
> On Tue, Aug 31, 2010 at 8:42 PM, <mailto:msb@chromium.org> wrote:
> 
> > LGTM
> >
> > Sorry for the delay. Was offline firefighting today.
> >
> >
> > http://codereview.chromium.org/3227006/show
> >
>

Powered by Google App Engine
This is Rietveld 408576698