Issue 3225003: Second attempt at landing http://codereview.chromium.org/3214005...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3225003: Second attempt at landing http://codereview.chromium.org/3214005... (Closed)

Created:
10 years, 3 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Second attempt at landing http://codereview.chromium.org/3214005 Factoring BuildUserAgent out to a separate lib for GCF can use it. TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57717

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -112 lines)			Patch
A	webkit/glue/user_agent.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	webkit/glue/user_agent.cc	View	1 chunk	+119 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	3 chunks	+1 line, -101 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	2 chunks	+35 lines, -11 lines	0 comments	Download