Tweaks to the SSL InfoBubble dialog.

Tweaks to the SSL InfoBubble dialog.

Fixed the mixed state icon not showing for section Connection. I overlooked the fact that we already check for mixed content, but reported state as error (whereas now we want warning).

Added link to help center explaining what this dialog means.

BUG=http://crbug.com/52916
TEST=SSL Infobubble should show link to help center and should show mixed content icon when, for example, you open an email in Gmail with an external image embedded in it.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57970

[Jay Civelli, 2010-08-30 16:27:02]

http://codereview.chromium.org/3221005/diff/5001/6004
File chrome/browser/views/page_info_bubble_view.cc (right):

http://codereview.chromium.org/3221005/diff/5001/6004#newcode95
chrome/browser/views/page_info_bubble_view.cc:95: info_bubble_(NULL) {
Initialize help_center_link_

http://codereview.chromium.org/3221005/diff/5001/6004#newcode137
chrome/browser/views/page_info_bubble_view.cc:137: layout->AddPaddingRow(0,
kPaddingAboveSeparator);
Could adding this separator be done in the for loop by removing the:
"if (i < count -1)" line?

[Finnur, 2010-08-30 17:11:48]

http://codereview.chromium.org/3221005/diff/5001/6004
File chrome/browser/views/page_info_bubble_view.cc (right):

http://codereview.chromium.org/3221005/diff/5001/6004#newcode95
chrome/browser/views/page_info_bubble_view.cc:95: info_bubble_(NULL) {
Technically, it is initialized in a function call from the constructor, but it
doesn't hurt to NULL it in the list...

http://codereview.chromium.org/3221005/diff/5001/6004#newcode137
chrome/browser/views/page_info_bubble_view.cc:137: layout->AddPaddingRow(0,
kPaddingAboveSeparator);
Good point.

On 2010/08/30 16:27:02, Jay Civelli wrote:
> Could adding this separator be done in the for loop by removing the:
> "if (i < count -1)" line?

[Jay Civelli, 2010-08-30 17:33:06]

LGTM