chrome_frame/urlmon_url_request.cc - Issue 3220001: Merge 57581 - Fix a crash when delegate_ goes away in ReadStream...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/urlmon_url_request.cc

Issue 3220001: Merge 57581 - Fix a crash when delegate_ goes away in ReadStream... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/472/src/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/urlmon_url_request.cc

===================================================================

--- chrome_frame/urlmon_url_request.cc (revision 57608)

+++ chrome_frame/urlmon_url_request.cc (working copy)

@@ -220,7 +220,9 @@

if (bytes_copied) {

++calling_delegate_;

DCHECK(id() != -1);

- delegate_->OnReadComplete(id(), read_data);

+ // The delegate can go away in the middle of ReadStream

+ if (delegate_)

+ delegate_->OnReadComplete(id(), read_data);

--calling_delegate_;

}

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »