Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 3218010: Fix mozilla and debug check failures.... (Closed)

Created:
10 years, 3 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix mozilla and debug check failures. This removes the expected failure of a mozilla test that we now pass (an empty array is returned if Array.splice is called with no arguments) and fixes debug check failure by allocating a new empty array using AllocateEmptyArray if splice is called with zero arguments (makes sure we can always create a handle). Committed: http://code.google.com/p/v8/source/detail?r=5377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/builtins.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
10 years, 3 months ago (2010-08-31 07:21:47 UTC) #1
Vyacheslav Egorov (Chromium)
10 years, 3 months ago (2010-08-31 07:25:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698