Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 3217005: Don't check BIOS vendor in hardware_Components test. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam
Modified:
9 years, 5 months ago
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Don't check BIOS vendor in hardware_Components test. Since the BIOS firmware is covered by RO hash and RW version. This check is not necessary. And this check needs DMI support of BIOS. Removing it can reduce the DMI support of BIOS. Change-Id: I5391efc8b7e3654e9f462f4d6a7323cca20cf237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M client/site_tests/hardware_Components/approved_components View 1 chunk +0 lines, -1 line 0 comments Download
M client/site_tests/hardware_Components/hardware_Components.py View 2 chunks +0 lines, -8 lines 0 comments Download
M client/site_tests/suite_Factory/test_list View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Wai-Hong Tam
10 years, 3 months ago (2010-08-28 07:05:42 UTC) #1
Randall Spangler
10 years, 3 months ago (2010-08-30 21:11:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698