Issue 3216010: Use SafeMemcmp() in RSAVerify() just to be safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3216010: Use SafeMemcmp() in RSAVerify() just to be safe. (Closed)

Created:
10 years, 3 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

Use SafeMemcmp() in RSAVerify() just to be safe. BUG=chrome-os-partner:832 TEST=make && make runtests Change-Id: I370021071b2b219c0db89cfaa015f4ff315c9204

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -18 lines)			Patch
	M	firmware/lib/cryptolib/rsa.c	View		2 chunks	+12 lines, -17 lines	0 comments	Download
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM (FYI you can use BUG=chrome-os-partner:832 and it'll log the fix to the right place)

10 years, 3 months ago (2010-08-30 15:47:32 UTC) #2

gauravsh

10 years, 3 months ago (2010-08-30 18:39:07 UTC) #3

On Mon, Aug 30, 2010 at 8:47 AM,  <rspangler@chromium.org> wrote:
> LGTM
>
> (FYI you can use
>    BUG=chrome-os-partner:832
> and it'll log the fix to the right place)

already using that. :)

>
>
> http://codereview.chromium.org/3216010/show
>



-- 
-g

Expand Messages | Collapse Messages