Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h

Issue 3214002: Add a term feature extractor for client-side phishing detection. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Add an extra comment/TODO about performance. Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h
diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h
index ef0e42e969272f40a33748827b959ee6cd9040fa..2b72d46aea82bfb7386534bfeaa8d062ae682da9 100644
--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h
+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h
@@ -49,7 +49,8 @@ class PhishingDOMFeatureExtractor {
// render thread for too long, the feature extractor may run in several
// chunks of work, posting a task to the current MessageLoop to continue
// processing. Once feature extraction is complete, |done_callback|
- // is run. PhishingDOMFeatureExtractor takes ownership of the callback.
+ // is run on the current thread. PhishingDOMFeatureExtractor takes
+ // ownership of the callback.
void ExtractFeatures(FeatureMap* features, DoneCallback* done_callback);
// Cancels any pending feature extraction. The DoneCallback will not be run.
@@ -61,7 +62,7 @@ class PhishingDOMFeatureExtractor {
struct FrameData;
struct PageFeatureState;
- // The maximum amount of time that we will spend on a single extraction
+ // The maximum amount of wall time that we will spend on a single extraction
// iteration before pausing to let other MessageLoop tasks run.
static const int kMaxTimePerChunkMs;
« no previous file with comments | « chrome/renderer/safe_browsing/features.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698