[Linux]Workaround issue 50485

[Linux]Workaround issue 50485

Please see http://crbug.com/50485 for details. This CL workarounds this issue by ignoring one "commit" signal triggered when resetting the gtk imcontext.

BUG=50485
TEST=See bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57867

[Evan Stade, 2010-08-26 23:51:17]

superficial LGTM, but I would rather you get whoever originally reviewed the
code to review this change (looks like tony/hbono)

[Hironori Bono, 2010-08-27 06:12:27]

> [Linux]Workaround issue 50485 

This description becomes a change log when landing this change and many people
use this change log to figure out what each change did and why. So, please write
this description more descriptive so Chromium developers (except you) can easily
get the said information without reading your change itself.

Regards,

Hironori Bono

[James Su, 2010-08-27 07:14:49]

Do I need to copy the description from the bug report? Or just add a comment to
let people read the bug report?

On 2010/08/27 06:12:27, hbono wrote:
> > [Linux]Workaround issue 50485 
> 
> This description becomes a change log when landing this change and many people
> use this change log to figure out what each change did and why. So, please
write
> this description more descriptive so Chromium developers (except you) can
easily
> get the said information without reading your change itself.
> 
> Regards,
> 
> Hironori Bono

[Hironori Bono, 2010-08-27 07:59:50]

I'm wondering if you understand my previous comment. I asked you to write about
the details of your change, not about the bug itself. For example, when you just
say "this change fixes Issue 50485", people usually ask questions about it (e.g.
"what does this change do?", "why does this change fix the issue?", etc.) I just
ask you to write answers for such frequently-asked-questions to avoid
unnecessary discussions.

Regards,

Hironori Bono

[James Su, 2010-08-27 16:26:04]

I did update the description. Isn't it enough? If you insist that it's not
enough, please do me a favor to write a better description. Thanks.

On 2010/08/27 07:59:50, hbono wrote:
> I'm wondering if you understand my previous comment. I asked you to write
about
> the details of your change, not about the bug itself. For example, when you
just
> say "this change fixes Issue 50485", people usually ask questions about it
(e.g.
> "what does this change do?", "why does this change fix the issue?", etc.) I
just
> ask you to write answers for such frequently-asked-questions to avoid
> unnecessary discussions.
> 
> Regards,
> 
> Hironori Bono

[Hironori Bono, 2010-08-28 16:18:39]

LGTM.
Just out of curiosity, does this workaround work also when ibus-hungul fixes it?

Regards,

Hironori Bono

[James Su, 2010-08-30 17:02:33]

Yes. It should work.

On 2010/08/28 16:18:39, hbono wrote:
> LGTM.
> Just out of curiosity, does this workaround work also when ibus-hungul fixes
it?
> 
> Regards,
> 
> Hironori Bono