Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 3213005: Linux: Enable symbol dumping on 64-bit Breakpad. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« breakpad/breakpad.gyp ('K') | « breakpad/breakpad.gyp ('k') | chrome/tools/build/linux/SYMBOLS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 57895)
+++ build/common.gypi (working copy)
@@ -304,10 +304,7 @@
}],
# All Chrome builds have breakpad symbols, but only process the
# symbols from official builds.
- # TODO(mmoss) dump_syms segfaults on x64. Enable once dump_syms and
- # crash server handle 64-bit symbols.
- ['(branding=="Chrome" and buildtype=="Official" and '
- 'target_arch=="ia32")', {
+ ['(branding=="Chrome" and buildtype=="Official")', {
'linux_dump_symbols%': 1,
}],
['toolkit_views==0', {
« breakpad/breakpad.gyp ('K') | « breakpad/breakpad.gyp ('k') | chrome/tools/build/linux/SYMBOLS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698