Linux: Enable symbol dumping on 64-bit Breakpad.

Linux: Enable symbol dumping on 64-bit Breakpad.

BUG=20737
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58050

[Lei Zhang, 2010-08-31 18:08:40]

ping (just in case you missed it)

[Michael Moss, 2010-08-31 18:22:53]

LGTM.

Also FYI, I think the dump files might be hard-coded in some buildbot scripts
(maybe the scripts that archive official builds?), so please check and update if
necessary.

http://codereview.chromium.org/3213005/diff/1/2
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/3213005/diff/1/2#newcode189
breakpad/breakpad.gyp:189: ['linux_breakpad==1', {
So this won't automatically happen for official builds now? Do you have updates
to those buildbot configs to make sure linux_breakpad is set?

[Lei Zhang, 2010-08-31 18:26:49]

On 2010/08/31 18:22:53, Michael Moss wrote:
> LGTM.
> 
> Also FYI, I think the dump files might be hard-coded in some buildbot scripts
> (maybe the scripts that archive official builds?), so please check and update
if
> necessary.

The buildbot scripts upload *.breakpad.*

> http://codereview.chromium.org/3213005/diff/1/2
> File breakpad/breakpad.gyp (right):
> 
> http://codereview.chromium.org/3213005/diff/1/2#newcode189
> breakpad/breakpad.gyp:189: ['linux_breakpad==1', {
> So this won't automatically happen for official builds now? Do you have
updates
> to those buildbot configs to make sure linux_breakpad is set?

in build/common.gypi, branding=="Chrome" sets linux_breakpad=1.

[Michael Moss, 2010-08-31 18:38:27]

Sounds good, thanks.

On Tue, Aug 31, 2010 at 11:26 AM,  <thestig@chromium.org> wrote:
> On 2010/08/31 18:22:53, Michael Moss wrote:
>>
>> LGTM.
>
>> Also FYI, I think the dump files might be hard-coded in some buildbot
>> scripts
>> (maybe the scripts that archive official builds?), so please check and
>> update
>
> if
>>
>> necessary.
>
> The buildbot scripts upload *.breakpad.*
>
>> http://codereview.chromium.org/3213005/diff/1/2
>> File breakpad/breakpad.gyp (right):
>
>> http://codereview.chromium.org/3213005/diff/1/2#newcode189
>> breakpad/breakpad.gyp:189: ['linux_breakpad==1', {
>> So this won't automatically happen for official builds now? Do you have
>
> updates
>>
>> to those buildbot configs to make sure linux_breakpad is set?
>
> in build/common.gypi, branding=="Chrome" sets linux_breakpad=1.
>
> http://codereview.chromium.org/3213005/show
>