Adding support for markerTextForListItem() to Chromium's LayoutTestController...

Adding support for markerTextForListItem() to Chromium's LayoutTestController.

TEST=none
BUG=53289
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57843

[dumi, 2010-08-26 23:13:21]

Chromium's side of the patch. WebKit's side is at
https://bugs.webkit.org/show_bug.cgi?id=44724.

[darin (slow to review), 2010-08-27 03:35:22]

LGTM w/ optional nit

http://codereview.chromium.org/3213001/diff/4001/5001
File webkit/tools/test_shell/layout_test_controller.cc (right):

http://codereview.chromium.org/3213001/diff/4001/5001#newcode1342
webkit/tools/test_shell/layout_test_controller.cc:1342: WebKit::WebElement
element;
nit: I recommend putting 'using WebKit::WebElement' and 'usng
WebKit::WebBindings' at the top of this file so you don't need to have the
WebKit:: prefix here.  there may be other instances of WebKit:: in this file
that could use similar treatment :-/

[dumi, 2010-08-27 03:47:06]

http://codereview.chromium.org/3213001/diff/4001/5001
File webkit/tools/test_shell/layout_test_controller.cc (right):

http://codereview.chromium.org/3213001/diff/4001/5001#newcode1342
webkit/tools/test_shell/layout_test_controller.cc:1342: WebKit::WebElement
element;
On 2010/08/27 03:35:22, darin wrote:
> nit: I recommend putting 'using WebKit::WebElement' and 'usng
> WebKit::WebBindings' at the top of this file so you don't need to have the
> WebKit:: prefix here.  there may be other instances of WebKit:: in this file
> that could use similar treatment :-/

done, for all WebKit::X references in this file.

[darin (slow to review), 2010-08-27 04:42:45]

Thanks!

On Thu, Aug 26, 2010 at 8:47 PM, <dumi@chromium.org> wrote:

>
> http://codereview.chromium.org/3213001/diff/4001/5001
> File webkit/tools/test_shell/layout_test_controller.cc (right):
>
> http://codereview.chromium.org/3213001/diff/4001/5001#newcode1342
> webkit/tools/test_shell/layout_test_controller.cc:1342:
> WebKit::WebElement element;
> On 2010/08/27 03:35:22, darin wrote:
>
>> nit: I recommend putting 'using WebKit::WebElement' and 'usng
>> WebKit::WebBindings' at the top of this file so you don't need to have
>>
> the
>
>> WebKit:: prefix here.  there may be other instances of WebKit:: in
>>
> this file
>
>> that could use similar treatment :-/
>>
>
> done, for all WebKit::X references in this file.
>
>
> http://codereview.chromium.org/3213001/show
>