Issue 3212012: image_to_usb: List available disks when /dev/sdX is specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3212012: image_to_usb: List available disks when /dev/sdX is specified (Closed)

Created:
10 years, 3 months ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

image_to_usb: List available disks when /dev/sdX is specified I'm lazy and sometimes copy and paste the output at the end of build_image verbatim and accidentally include the newline at the end. This gives a more useful output for that case. Change-Id: I1a4abefa884a91cb75dfe2779c79b3ef4b60e807 BUG=none TEST=./image_to_usb --from=../build/images/x86-generic/latest --to=/dev/sdX (and /dev/sde)

Patch Set 1 #

Patch Set 2 : Just change the default #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	image_to_usb.sh	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Olof Johansson

Instead of also checking for empty --to? Good idea. Done, PTAL.

10 years, 3 months ago (2010-08-31 16:01:07 UTC) #3

LGTM, nice

Expand Messages | Collapse Messages