Issue 3211002: Fast string construct stub (ia32 only for now).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3211002: Fast string construct stub (ia32 only for now). (Closed)

Created:
10 years, 4 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
antonm, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fast string construct stub (ia32 only for now). Committed: http://code.google.com/p/v8/source/detail?r=5357

Patch Set 1 #

Patch Set 2 : Simpler map loading #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -24 lines)			Patch
M	src/arm/builtins-arm.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1	5 chunks	+128 lines, -13 lines	1 comment	Download
M	src/ia32/macro-assembler-ia32.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/v8-counters.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

Anton pointed out that we can simplify the initial map loading since the function is ...

10 years, 4 months ago (2010-08-26 13:43:41 UTC) #3

antonm

10 years, 4 months ago (2010-08-26 13:51:16 UTC) #5

LGTM too

http://codereview.chromium.org/3211002/diff/4001/5004
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/3211002/diff/4001/5004#newcode1203
src/ia32/builtins-ia32.cc:1203: __ LoadGlobalFunctionInitialMap(edi, ecx);
maybe add a check under FLAG_debug_code above this line.

Expand Messages | Collapse Messages