Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 321001: Fix bug that meant that dependent tests were never reported as... (Closed)

Created:
11 years, 2 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug that meant that dependent tests were never reported as failing (though they could still crash). (Cache the result of the test in the output object, not in the test object which is reused from the prerequisite to the dependent.) Committed: http://code.google.com/p/v8/source/detail?r=3115

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M test/cctest/cctest.status View 1 chunk +11 lines, -0 lines 1 comment Download
M test/cctest/test-serialize.cc View 1 chunk +17 lines, -0 lines 1 comment Download
M tools/test.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
11 years, 2 months ago (2009-10-22 13:30:04 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/321001/diff/1/2 File test/cctest/cctest.status (right): http://codereview.chromium.org/321001/diff/1/2#newcode36 Line 36: # This is about to go away ...
11 years, 2 months ago (2009-10-22 13:33:28 UTC) #2
Tobias Kaes
11 years, 2 months ago (2009-10-23 09:11:40 UTC) #3
On 2009/10/22 13:33:28, Kasper Lund wrote:
> LGTM.
> 
> http://codereview.chromium.org/321001/diff/1/2
> File test/cctest/cctest.status (right):
> 
> http://codereview.chromium.org/321001/diff/1/2#newcode36
> Line 36: # This is about to go away anyway.
> Maybe elaborate (a bit) on why they are going away?
> 
> http://codereview.chromium.org/321001/diff/1/3
> File test/cctest/test-serialize.cc (right):
> 
> http://codereview.chromium.org/321001/diff/1/3#newcode291
> Line 291: extern "C" void V8_Fatal(const char* file, int line, const char*
> format, ...);
> Is that really necessary? You trust V8_Fatal over CHECK, I guess? It looks
> pretty ugly.

In the committed version (r3115) it still has the V8_Fatal import but doesn't
seem to use it ... probably could be removed?

Powered by Google App Engine
This is Rietveld 408576698