Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 3209003: Limit the number of crash reports to enqueue at once (Closed)

Created:
10 years, 4 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Limit the number of crash reports to enqueue at once BUG=5357 Change-Id: Ib21086cdd34c938def885d625a165ba2fa0879a4

Patch Set 1 #

Total comments: 10

Patch Set 2 : Respond to reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -2 lines) Patch
M crash_collector.h View 2 chunks +12 lines, -1 line 0 comments Download
M crash_collector.cc View 1 3 chunks +45 lines, -0 lines 0 comments Download
M crash_collector_test.cc View 1 3 chunks +55 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kmixter1
10 years, 4 months ago (2010-08-25 21:39:37 UTC) #1
petkov
http://codereview.chromium.org/3209003/diff/1/2 File crash_collector.cc (right): http://codereview.chromium.org/3209003/diff/1/2#newcode163 crash_collector.cc:163: DIR* dir = opendir(crash_directory.value().c_str()); Any reason why you aren't ...
10 years, 4 months ago (2010-08-25 21:50:54 UTC) #2
kmixter1
PTAL http://codereview.chromium.org/3209003/diff/1/2 File crash_collector.cc (right): http://codereview.chromium.org/3209003/diff/1/2#newcode163 crash_collector.cc:163: DIR* dir = opendir(crash_directory.value().c_str()); On 2010/08/25 21:50:54, petkov ...
10 years, 4 months ago (2010-08-26 19:42:00 UTC) #3
petkov
10 years, 4 months ago (2010-08-26 20:25:30 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698