Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 3208007: Add final part of IPC plumbing for FileSystem API (Closed)

Created:
10 years, 4 months ago by kinuko
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add final part of IPC plumbing for FileSystem API. BUG=32277 TEST=none; to be added when we have complete implementation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57915

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -25 lines) Patch
M chrome/browser/file_system/file_system_dispatcher_host.h View 1 1 chunk +22 lines, -3 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.cc View 1 2 chunks +58 lines, -2 lines 0 comments Download
M chrome/common/common_param_traits.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/common_param_traits.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/common/file_system/file_system_dispatcher.h View 1 2 chunks +40 lines, -5 lines 0 comments Download
M chrome/common/file_system/file_system_dispatcher.cc View 1 4 chunks +83 lines, -4 lines 0 comments Download
M chrome/common/file_system/webfilesystem_impl.cc View 1 chunk +24 lines, -8 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 3 chunks +46 lines, -3 lines 0 comments Download
M chrome/common/render_messages_params.h View 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/common/render_messages_params.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/common/webkit_param_traits.h View 1 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
kinuko
10 years, 4 months ago (2010-08-27 00:07:17 UTC) #1
kinuko
On 2010/08/27 00:07:17, Kinuko Yasuda wrote: > Right now I'm abusing WebKit structures in filesystem ...
10 years, 4 months ago (2010-08-27 00:15:33 UTC) #2
Eric U.
Some of the param_traits stuff is a bit hazy to me; I'd like someone who's ...
10 years, 4 months ago (2010-08-27 00:35:33 UTC) #3
kinuko
http://codereview.chromium.org/3208007/diff/1/2 File chrome/browser/file_system/file_system_dispatcher_host.cc (right): http://codereview.chromium.org/3208007/diff/1/2#newcode110 chrome/browser/file_system/file_system_dispatcher_host.cc:110: bool for_directory) { On 2010/08/27 00:35:33, Eric U. wrote: ...
10 years, 3 months ago (2010-08-27 18:26:15 UTC) #4
michaeln
10 years, 3 months ago (2010-08-27 19:05:39 UTC) #5
lgtm

http://codereview.chromium.org/3208007/diff/13001/14012
File chrome/common/webkit_param_traits.h (right):

http://codereview.chromium.org/3208007/diff/13001/14012#newcode333
chrome/common/webkit_param_traits.h:333: struct
SimilarTypeTraits<WebKit::WebFileSystem::Type> {
ah... i like this trait!

Powered by Google App Engine
This is Rietveld 408576698