Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 3206003: Autorestart on update should happen when (among other things), the browser is... (Closed)

Created:
10 years, 4 months ago by prasadt
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Autorestart on update should happen when (among other things), the browser is in KeepAlive mode. The condition to check that in CanAutorestartForUpdate() is reversed. BUG=none TEST=On Linux - Change BrowserProcessImpl::StartAutoupdateTimer() function to change the timer from 6hrs to 30 seconds. Build and run chrome with --no-startup-window and --keep-alive-for-test flags. Run "touch" on browser exe to fake an update. Wait for 30 seconds and verify that the browser shuts down and restarts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Andrew T Wilson (Slow)
10 years, 4 months ago (2010-08-24 16:51:19 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698