the new test to upload factory logs to FTP site

the new test to upload factory logs to FTP site

To assign target information, we will add customization section in
suite_Factory/control. That part will be included in another refine CL:
http://codereview.chromium.org/3180022/show

BUG=chrome-os-partner:827
TEST=manual

Change-Id: I65bf2415d1d5313684a7ea749232b28d33d783ab

[Tammo Spalink, 2010-08-25 03:22:09]

http://codereview.chromium.org/3206001/diff/3001/4001
File client/site_tests/factory_UploadLogs/factory_UploadLogs.py (right):

http://codereview.chromium.org/3206001/diff/3001/4001#newcode33
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:33: hashval =
hashlib.sha1(content).hexdigest()
this is 40 chars long, right?

http://codereview.chromium.org/3206001/diff/3001/4001#newcode72
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:72: dest =
destination.copy()
how about:
dest = DEFAULT_DESTINATION_PARAM.copy()
dest.update(destination)

http://codereview.chromium.org/3206001/diff/3001/4001#newcode76
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:76: dest_name =
dest_name + '.gz'
are we worried about length limits here?  i think some systems (eg mac-os)
currently have 30 char limits, no?

[Hung-Te, 2010-08-25 03:46:51]

http://codereview.chromium.org/3206001/diff/3001/4001
File client/site_tests/factory_UploadLogs/factory_UploadLogs.py (right):

http://codereview.chromium.org/3206001/diff/3001/4001#newcode33
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:33: hashval =
hashlib.sha1(content).hexdigest()
ex: 06a5161bcc4a2e3c0ed3e1f5d9669ebcdfa7342d
yes.

http://codereview.chromium.org/3206001/diff/3001/4001#newcode72
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:72: dest =
destination.copy()
I'd change to dest = {} then dest.update(DEFAULT_DESTINATION_PARAM) just as you
did...

http://codereview.chromium.org/3206001/diff/3001/4001#newcode76
client/site_tests/factory_UploadLogs/factory_UploadLogs.py:76: dest_name =
dest_name + '.gz'
I don't think so.
http://en.wikipedia.org/wiki/Filename
Most modern file systems support more than 254 characters.

[Tammo Spalink, 2010-08-25 03:55:32]

lgtm -- maybe need to think about UI for adding network, but lets check stuff in
and then worry about UI issues after trying it ourselves