Switch kRestoreBackgroundContents to kDisableRestoreBackgroundContents

Fix to change the sense (and name) of kRestoreBackgroundContents to be kDisableRestoreBackgroundContents

BUG=52793
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56945

[Andrew T Wilson (Slow), 2010-08-20 22:18:30]

http://codereview.chromium.org/3202004/diff/2001/3002
File chrome/browser/background_contents_service_unittest.cc (right):

http://codereview.chromium.org/3202004/diff/2001/3002#newcode28
chrome/browser/background_contents_service_unittest.cc:28:
command_line_->AppendSwitch(switches::kDisableRestoreBackgroundContents);
I think you want to delete this line entirely. The old code was trying to launch
chrome with "restore background contents" enabled. So since that's the new
default, you should not have to do anything.

[non.chromium.rickcam, 2010-08-20 22:40:54]

Belatedly sending CR follow-up

http://codereview.chromium.org/3202004/diff/2001/3002
File chrome/browser/background_contents_service_unittest.cc (right):

http://codereview.chromium.org/3202004/diff/2001/3002#newcode28
chrome/browser/background_contents_service_unittest.cc:28:
command_line_->AppendSwitch(switches::kDisableRestoreBackgroundContents);
On 2010/08/20 22:18:30, Andrew T Wilson wrote:
> I think you want to delete this line entirely. The old code was trying to
launch
> chrome with "restore background contents" enabled. So since that's the new
> default, you should not have to do anything.

Done.

[Andrew T Wilson (Slow), 2010-08-21 00:03:16]

LGTM. It passed the trybots also, so we can land this today if you like.

[non.chromium.rickcam, 2010-08-21 02:50:57]

Only one column has yet to "go green".  I'll look in on it a bit later as
well.

Rick


On Fri, Aug 20, 2010 at 5:03 PM, <atwilson@chromium.org> wrote:

> LGTM. It passed the trybots also, so we can land this today if you like.
>
> http://codereview.chromium.org/3202004/show
>