Some minor fixes to remove unnecessary includes and do fwd declaration instea...

Some minor fixes to remove unnecessary includes and do fwd declaration instead.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56980

[oshima, 2010-08-20 21:01:58]

http://codereview.chromium.org/3202003/diff/1/2
File chrome/browser/views/accessibility_event_router_views.cc (left):

http://codereview.chromium.org/3202003/diff/1/2#oldcode23
chrome/browser/views/accessibility_event_router_views.cc:23: using views::View;
This is allowed, so it's up to you.

http://codereview.chromium.org/3202003/diff/1/4
File chrome/browser/views/accessible_toolbar_view.h (right):

http://codereview.chromium.org/3202003/diff/1/4#newcode14
chrome/browser/views/accessible_toolbar_view.h:14: #include
"views/widget/root_view.h"
Why you need root view here?

[Chaitanya, 2010-08-20 21:20:45]

On 2010/08/20 21:01:58, oshima wrote:
> http://codereview.chromium.org/3202003/diff/1/2
> File chrome/browser/views/accessibility_event_router_views.cc (left):
> 
> http://codereview.chromium.org/3202003/diff/1/2#oldcode23
> chrome/browser/views/accessibility_event_router_views.cc:23: using
views::View;
> This is allowed, so it's up to you.
> 
> http://codereview.chromium.org/3202003/diff/1/4
> File chrome/browser/views/accessible_toolbar_view.h (right):
> 
> http://codereview.chromium.org/3202003/diff/1/4#newcode14
> chrome/browser/views/accessible_toolbar_view.h:14: #include
> "views/widget/root_view.h"
> Why you need root view here?

It gives me the following error otherwise:
field 'focus_search_' has incomplete type

[Chaitanya, 2010-08-20 21:28:05]

On 2010/08/20 21:20:45, Chaitanya wrote:
> On 2010/08/20 21:01:58, oshima wrote:
> > http://codereview.chromium.org/3202003/diff/1/2
> > File chrome/browser/views/accessibility_event_router_views.cc (left):
> > 
> > http://codereview.chromium.org/3202003/diff/1/2#oldcode23
> > chrome/browser/views/accessibility_event_router_views.cc:23: using
> views::View;
> > This is allowed, so it's up to you.
> > 
> > http://codereview.chromium.org/3202003/diff/1/4
> > File chrome/browser/views/accessible_toolbar_view.h (right):
> > 
> > http://codereview.chromium.org/3202003/diff/1/4#newcode14
> > chrome/browser/views/accessible_toolbar_view.h:14: #include
> > "views/widget/root_view.h"
> > Why you need root view here?
> 
> It gives me the following error otherwise:
> field 'focus_search_' has incomplete type

Maybe I just need to include "views/focus/focus_search.h" in
accessible_toolbar_view.h

[Chaitanya, 2010-08-20 21:29:28]

http://codereview.chromium.org/3202003/diff/1/4
File chrome/browser/views/accessible_toolbar_view.h (right):

http://codereview.chromium.org/3202003/diff/1/4#newcode14
chrome/browser/views/accessible_toolbar_view.h:14: #include
"views/widget/root_view.h"
Including focus_search.h instead.
If I don't include this, I am getting this error:
field 'focus_search_' has incomplete type

On 2010/08/20 21:01:58, oshima wrote:
> Why you need root view here?

[oshima, 2010-08-20 21:35:05]

LGTM for now.

Ideally, you should use scoped_ptr<FocusSearch> instead of
embedding the instance here, then you can use forward declaration. I'll leave
the decision to you guys.

[Chaitanya, 2010-08-20 22:55:26]

Done. Changed to scoped_ptr.
Dominic, can you take a look at this change as well?

On 2010/08/20 21:35:05, oshima wrote:
> LGTM for now.
> 
> Ideally, you should use scoped_ptr<FocusSearch> instead of
> embedding the instance here, then you can use forward declaration. I'll leave
> the decision to you guys.

[dmazzoni, 2010-08-20 23:02:29]

LGTM.

[oshima, 2010-08-20 23:58:28]

LGTM

On Fri, Aug 20, 2010 at 4:02 PM, <dmazzoni@chromium.org> wrote:

> LGTM.
>
>
>
> http://codereview.chromium.org/3202003/show
>