Fix for pyauto dangerous downloads functional test.

chrome/test/functional/downloads.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import filecmp
 import logging
 import os
 import shutil
 import sys
 import tempfile
 import time
 import urllib
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 
 
 class DownloadsTest(pyauto.PyUITest):
   """TestCase for Downloads."""
 
+  def _GetDangerousDownload(self):
+    """Returns the file url for a dangerous download for this OS."""
+    sub_path = os.path.join(self.DataDir(), 'downloads', 'dangerous')
+    if self.IsMac():
+      return os.path.join(sub_path, 'dangerous.dmg')
+    return os.path.join(sub_path, 'dangerous.exe')
+
   def _EqualFileContents(self, file1, file2):
     """Determine if 2 given files have the same contents."""
     if not (os.path.exists(file1) and os.path.exists(file2)):
       return False
     return filecmp.cmp(file1, file2, shallow=False)
 
   def _GetDownloadId(self, download_index=0):
     """Return the download id for the download at the given index.
 
     Args:
@@ skipping 28 matching lines @@
 
     # Verify that the download shelf is visible
     self.assertTrue(self.IsDownloadShelfVisible())
 
     # Verify that the file was correctly downloaded
     self.assertTrue(os.path.exists(downloaded_pkg))
     self.assertTrue(self._EqualFileContents(file_path, downloaded_pkg))
 
   def testDownloadDangerousFiles(self):
     """Verify that we can download and save dangerous files."""
-    test_dir = os.path.abspath('.')
-    # This file is a .py file which is "dangerous"
-    file_path = os.path.join(test_dir, 'downloads.py')
+    file_path = self._GetDangerousDownload()
     file_url = self.GetFileURLForPath(file_path)
     downloaded_pkg = os.path.join(self.GetDownloadDirectory().value(),
-                                  'downloads.py')
+                                  os.path.basename(file_path))
     os.path.exists(downloaded_pkg) and os.remove(downloaded_pkg)
 
     self.DownloadAndWaitForStart(file_url)
     self.PerformActionOnDownload(self._GetDownloadId(),
                                  'save_dangerous_download')
     self.WaitForDownloadToComplete(downloaded_pkg)
 
     # Verify that the file was downloaded.
     self.assertTrue(os.path.exists(downloaded_pkg))
     self.assertTrue(self._EqualFileContents(file_path, downloaded_pkg))
@@ skipping 151 matching lines @@
                      'Download shelf persisted browser restart.')
     # Verify that the download history persists.
     downloads = self.GetDownloadsInfo().Downloads()
     self.assertEqual(1, len(downloads))
     self.assertEqual('a_zip_file.zip', downloads[0]['file_name'])
     self.assertEqual(file_url, downloads[0]['url'])
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()