Issue 3200009: entd: Cope with timeout during user pin initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3200009: entd: Cope with timeout during user pin initialization (Closed)

Created:
10 years, 4 months ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, rginda, gauravsh

Base URL:
http://src.chromium.org/git/entd.git

Visibility:
Public.

Description

entd: Cope with timeout during user pin initialization Turns out that when we fail due to a timeout when initializing the user pin, we end up without some important files in the TOK_OBJ directory. This patch detects that problem and removes the broken token. It also makes sure the script emits a log line explaining what it found each time it runs. BUG=chromium-os:6064 TEST=tested various permutations in chroot. Change-Id: I60c6131224da24bae71abd4c9287216688f1e5cf

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	bin/fix_pkcs11_token.sh	View		1 chunk	+22 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 4 months ago (2010-08-25 00:33:13 UTC) #2

LGTM with nit

http://codereview.chromium.org/3200009/diff/1/2
File bin/fix_pkcs11_token.sh (right):

http://codereview.chromium.org/3200009/diff/1/2#newcode29
bin/fix_pkcs11_token.sh:29: -e "$USER_TOKEN_DIR/TOK_OBJ/70000000" ]; then
-f or -e, be consistent.

Expand Messages | Collapse Messages