Add all pfq configurations and add build_image / run_unit_tests.

Add all pfq configurations and add build_image / run_unit_tests.

BUG=5468
TEST=Ran default and ran x86-generic.  Took board values from master.cfg in buildbot

[sosa, 2010-08-24 23:16:39]

ping :D

[scottz-goog, 2010-08-25 01:33:46]

Pong ;)

A few questions and I think you added parts to RunCommand that you can actually
use here? 

-Scott

On 2010/08/24 23:16:39, sosa wrote:
> ping :D

[scottz-goog, 2010-08-25 01:34:04]

oh I see if i reply it doesn't publish my drafts. Lame.

http://codereview.chromium.org/3200006/diff/2001/3001
File bin/cbuildbot.py (right):

http://codereview.chromium.org/3200006/diff/2001/3001#newcode104
bin/cbuildbot.py:104: RunCommand(['./enter_chroot.sh', '--', './build_image'],
cwd=cwd)
didn't you modify RunCommand to allow enter_chroot = True?

http://codereview.chromium.org/3200006/diff/2001/3001#newcode198
bin/cbuildbot.py:198: _BuildImage(buildroot)
I know you didn't start this but can we start to separate these with spaces :)
It all looks scrunched together especially with _FunctionNames

So i'd say
If 
  xx
SPACE
_functionOfDoom

http://codereview.chromium.org/3200006/diff/2001/3002
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/3200006/diff/2001/3002#newcode6
bin/cbuildbot_config.py:6: 
Perhaps a overall docstring that exaplins some of the things below. unittests
and board are pretty clear but uprev isn't clear to me. If I am off my rocker
then ignore this :)

http://codereview.chromium.org/3200006/diff/2001/3002#newcode30
bin/cbuildbot_config.py:30: 'uprev' : True,
Do we want this to uprev anything? This target is lower priority.

http://codereview.chromium.org/3200006/diff/2001/3002#newcode35
bin/cbuildbot_config.py:35: 'uprev' : True,
same as above.

[sosa, 2010-08-26 23:00:55]

PTAL

http://codereview.chromium.org/3200006/diff/2001/3001
File bin/cbuildbot.py (right):

http://codereview.chromium.org/3200006/diff/2001/3001#newcode104
bin/cbuildbot.py:104: RunCommand(['./enter_chroot.sh', '--', './build_image'],
cwd=cwd)
On 2010/08/25 01:34:04, scottz-goog wrote:
> didn't you modify RunCommand to allow enter_chroot = True?

Done. I was waiting to rebase once I pushed those changes.

http://codereview.chromium.org/3200006/diff/2001/3001#newcode198
bin/cbuildbot.py:198: _BuildImage(buildroot)
On 2010/08/25 01:34:04, scottz-goog wrote:
> I know you didn't start this but can we start to separate these with spaces :)
> It all looks scrunched together especially with _FunctionNames
> 
> So i'd say
> If 
>   xx
> SPACE
> _functionOfDoom
> 

Done.

http://codereview.chromium.org/3200006/diff/2001/3002
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/3200006/diff/2001/3002#newcode6
bin/cbuildbot_config.py:6: 
On 2010/08/25 01:34:04, scottz-goog wrote:
> Perhaps a overall docstring that exaplins some of the things below. unittests
> and board are pretty clear but uprev isn't clear to me. If I am off my rocker
> then ignore this :)

Done.

http://codereview.chromium.org/3200006/diff/2001/3002#newcode30
bin/cbuildbot_config.py:30: 'uprev' : True,
It should uprev but not commit (should uprev just like the master to test the
new changes).  Check cbuildbot.py ... there's a check for only pushing uprevs
from the master.

On 2010/08/25 01:34:04, scottz-goog wrote:
> Do we want this to uprev anything? This target is lower priority.

http://codereview.chromium.org/3200006/diff/2001/3002#newcode35
bin/cbuildbot_config.py:35: 'uprev' : True,
On 2010/08/25 01:34:04, scottz-goog wrote:
> same as above.
Ditto

[scottz-goog, 2010-08-27 16:18:55]

LGTM

Thank you for adding the docstring in cbuildbot_config that definitely clears
things up for me!

On 2010/08/26 23:00:55, sosa wrote:
> PTAL
> 
> http://codereview.chromium.org/3200006/diff/2001/3001
> File bin/cbuildbot.py (right):
> 
> http://codereview.chromium.org/3200006/diff/2001/3001#newcode104
> bin/cbuildbot.py:104: RunCommand(['./enter_chroot.sh', '--', './build_image'],
> cwd=cwd)
> On 2010/08/25 01:34:04, scottz-goog wrote:
> > didn't you modify RunCommand to allow enter_chroot = True?
> 
> Done. I was waiting to rebase once I pushed those changes.
> 
> http://codereview.chromium.org/3200006/diff/2001/3001#newcode198
> bin/cbuildbot.py:198: _BuildImage(buildroot)
> On 2010/08/25 01:34:04, scottz-goog wrote:
> > I know you didn't start this but can we start to separate these with spaces
:)
> > It all looks scrunched together especially with _FunctionNames
> > 
> > So i'd say
> > If 
> >   xx
> > SPACE
> > _functionOfDoom
> > 
> 
> Done.
> 
> http://codereview.chromium.org/3200006/diff/2001/3002
> File bin/cbuildbot_config.py (right):
> 
> http://codereview.chromium.org/3200006/diff/2001/3002#newcode6
> bin/cbuildbot_config.py:6: 
> On 2010/08/25 01:34:04, scottz-goog wrote:
> > Perhaps a overall docstring that exaplins some of the things below.
unittests
> > and board are pretty clear but uprev isn't clear to me. If I am off my
rocker
> > then ignore this :)
> 
> Done.
> 
> http://codereview.chromium.org/3200006/diff/2001/3002#newcode30
> bin/cbuildbot_config.py:30: 'uprev' : True,
> It should uprev but not commit (should uprev just like the master to test the
> new changes).  Check cbuildbot.py ... there's a check for only pushing uprevs
> from the master.
> 
> On 2010/08/25 01:34:04, scottz-goog wrote:
> > Do we want this to uprev anything? This target is lower priority.
> 
> http://codereview.chromium.org/3200006/diff/2001/3002#newcode35
> bin/cbuildbot_config.py:35: 'uprev' : True,
> On 2010/08/25 01:34:04, scottz-goog wrote:
> > same as above.
> Ditto