Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 3200001: Hookup role descriptions for webkit specific strings. Only doing this for ac... (Closed)

Created:
10 years, 4 months ago by David Tseng
Modified:
9 years, 5 months ago
Reviewers:
feldstein, dmazzoni
CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Hookup role descriptions for webkit specific strings. Only doing this for accessibility roles we know about. BUG=none. TEST=Use VoiceOver to confirm the proper role descriptions are read. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57006

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/cocoa/browser_accessibility.mm View 1 3 chunks +18 lines, -1 line 0 comments Download
M webkit/glue/webkit_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
David Tseng
10 years, 4 months ago (2010-08-19 20:14:57 UTC) #1
feldstein
http://codereview.chromium.org/3200001/diff/1/2 File chrome/browser/cocoa/browser_accessibility.mm (right): http://codereview.chromium.org/3200001/diff/1/2#newcode187 chrome/browser/cocoa/browser_accessibility.mm:187: I can see us having to add a lot ...
10 years, 4 months ago (2010-08-20 03:01:37 UTC) #2
David Tseng
> > http://codereview.chromium.org/3200001/diff/1/2 > File chrome/browser/cocoa/browser_accessibility.mm (right): > > http://codereview.chromium.org/3200001/diff/1/2#newcode187 > chrome/browser/cocoa/browser_accessibility.mm:187: > I can ...
10 years, 4 months ago (2010-08-20 16:09:41 UTC) #3
feldstein
10 years, 4 months ago (2010-08-20 18:20:47 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698