Issue 3199015: Don't generate quitquitquit files when running unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3199015: Don't generate quitquitquit files when running unit tests. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Don't generate quitquitquit files when running unit tests. BUG=none TEST=unit tests Change-Id: I6eb69fcac53c257390b640767a3f547478f792b2

Patch Set 1 #

Patch Set 2 : save one line #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	.gitignore	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	subprocess_unittest.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 4 months ago (2010-08-24 20:03:05 UTC) #2

LGTM

On Tue, Aug 24, 2010 at 11:45 AM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> Don't generate quitquitquit files when running unit tests.
>
> BUG=none
> TEST=unit tests
>
> Change-Id: I6eb69fcac53c257390b640767a3f547478f792b2
>
> Please review this at http://codereview.chromium.org/3199015/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M .gitignore
>  M subprocess_unittest.cc
>
>
> Index: .gitignore
> diff --git a/.gitignore b/.gitignore
> index
>
983594ec5655b414f27410c81ab17d77b826a5b8..976432140079a63b7f775f11abdb253f7f95354d
> 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -18,7 +18,6 @@
>  /html/
>  /marshal.glibmarshal.c
>  /marshal.glibmarshal.h
> -/quitquitquit*
>  /test_http_server
>  /update_engine
>  /update_engine.dbusclient.h
> Index: subprocess_unittest.cc
> diff --git a/subprocess_unittest.cc b/subprocess_unittest.cc
> index
>
65e56e6ca431d17cf40e218d3a1e9b15cc66343f..10dccbe559f81f395adefeef6da631888cfcd65e
> 100644
> --- a/subprocess_unittest.cc
> +++ b/subprocess_unittest.cc
> @@ -94,9 +94,9 @@ gboolean ExitWhenDone(gpointer data) {
>   if (cancel_test_data->spawned && !Subprocess::Get().SubprocessInFlight())
> {
>     // tear down the sub process
>     printf("tear down time\n");
> -    int status =
> -        System(StringPrintf("wget http://127.0.0.1:%d/quitquitquit",
> -                            kLocalHttpPort));
> +    int status = System(
> +        StringPrintf("wget -O /dev/null http://127.0.0.1:%d
> /quitquitquit",
> +                     kLocalHttpPort));
>     EXPECT_NE(-1, status) << "system() failed";
>     EXPECT_TRUE(WIFEXITED(status))
>         << "command failed to run or died abnormally";
>
>
>

Expand Messages | Collapse Messages