Issue 3198006: Fix search engine dialog top image for RTL languages. The search engine dial...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3198006: Fix search engine dialog top image for RTL languages. The search engine dial... (Closed)

Created:
10 years, 4 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix search engine dialog top image for RTL languages. The search engine dialog shows an image of the omnibox at the top of the dialog box; in RTL languages, this image needs to be reversed and moved to the left. BUG=52769 TEST=search engine dialog looks correct in RTL languages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56997

Patch Set 1 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/first_run_search_engine_view.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages