Issue 3197018: Refactor: change the spdy session pool key to take a ProxyServer instead of a stri...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3197018: Refactor: change the spdy session pool key to take a ProxyServer instead of a stri... (Closed)

Created:
10 years, 4 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Refactor: change the spdy session pool key to take a ProxyServer instead of a string representation of the proxy server. BUG=52668 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57297

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -22 lines)			Patch
M	net/http/http_network_transaction_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/http/http_stream_request.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_server.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/proxy/proxy_server.cc	View		2 chunks	+17 lines, -7 lines	0 comments	Download
M	net/proxy/proxy_server_unittest.cc	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_http_stream_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_session_pool.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_stream_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eroman

This is the change you suggested to me in that other code review (broke it ...

10 years, 4 months ago (2010-08-25 05:19:23 UTC) #1

LGTM!