Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/heapcheck/PRESUBMIT.py

Issue 3197014: Heapchecker: Add presubmit checks for suppressions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/heapcheck/PRESUBMIT.py
===================================================================
--- tools/heapcheck/PRESUBMIT.py (revision 57122)
+++ tools/heapcheck/PRESUBMIT.py (working copy)
@@ -21,11 +21,11 @@
if skip_next_line:
skip_next_line = False
continue
- if line == '{' or line == "Memcheck:Param":
+ if line == '{':
skip_next_line = True
continue
if (line.startswith('fun:') or line.startswith('obj:') or
- line.startswith('Memcheck:') or line == '}' or
+ line == 'Heapcheck:Leak' or line == '}' or
line == '...'):
continue
if func_re.match(line):
@@ -41,6 +41,3 @@
def CheckChangeOnCommit(input_api, output_api):
return CheckChange(input_api, output_api)
-
-def GetPreferredTrySlaves():
- return ['linux_valgrind', 'mac_valgrind']
Property changes on: tools/heapcheck/PRESUBMIT.py
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698