Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 3197012: [Mac] Add diagnostic logging to AmIBundled() to help with bot failures.... (Closed)

Created:
10 years, 4 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

[Mac] Add diagnostic logging to AmIBundled() to help with bot failures. This change should be reverted as soon as we figure out what's going wrong. BUG=52918 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57088

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M base/mac_util.mm View 1 2 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitrao (ping after 24h)
Is this what you had in mind for logging? Also, CFStringCreateWithCharacters() needs to be matched ...
10 years, 4 months ago (2010-08-23 17:52:00 UTC) #1
Avi (use Gerrit)
CF Create calls indicate that an object is created and returned with a +1 retain ...
10 years, 4 months ago (2010-08-23 17:56:45 UTC) #2
TVL
that's the basic idea. should add a bug= for the bug phajdan.jr is looking at ...
10 years, 4 months ago (2010-08-23 18:00:20 UTC) #3
rohitrao (ping after 24h)
Switched to scoped_cftyperef and LOG(ERROR).
10 years, 4 months ago (2010-08-23 18:55:04 UTC) #4
TVL
lg. queue up a cl to remove the non error cases so we make sure ...
10 years, 4 months ago (2010-08-23 19:00:19 UTC) #5
Avi (use Gerrit)
10 years, 4 months ago (2010-08-23 19:03:39 UTC) #6
(my comment was drive-by)

Powered by Google App Engine
This is Rietveld 408576698