Issue 3197009: Remove wstrings in bookmarks, part 10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3197009: Remove wstrings in bookmarks, part 10. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Remove wstrings in bookmarks, part 10. This converts the text parameter in GetBookmarksContainingText() and DoesBookmarkContainText() to string16. (The languages parameter will wait until I decide what I want for languages parameters in general.) BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57008

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	chrome/browser/bookmarks/bookmark_utils.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils_unittest.cc	View	4 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

I'm so confident, I'm sending it for review before it's even been compiled.

10 years, 4 months ago (2010-08-22 01:33:17 UTC) #1

Miranda Callahan

10 years, 4 months ago (2010-08-22 02:06:25 UTC) #2

On 2010/08/22 01:33:17, viettrungluu wrote:
> I'm so confident, I'm sending it for review before it's even been compiled.

I'm so confident, I'm going to give you an LGTM even though the trybot is being
recalcitrant.  Because I'm sure you've tested this on your own machine!

Expand Messages | Collapse Messages