Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 3195028: Add inlining of binary smi operations in the full codegens on IA32... (Closed)

Created:
10 years, 4 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Add inlining of binary smi operations in the full codegens on IA32 and x64 (on IA32 we even fold constants into the instructions for a more compact representation) and prepare the ARM full codegen for the doing the same there. Committed: http://code.google.com/p/v8/source/detail?r=5351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+629 lines, -99 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +57 lines, -28 lines 0 comments Download
M src/ast.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/full-codegen.h View 4 chunks +52 lines, -1 line 0 comments Download
M src/full-codegen.cc View 2 chunks +34 lines, -12 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +362 lines, -28 lines 0 comments Download
M src/token.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +116 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 4 months ago (2010-08-26 08:37:34 UTC) #1
fschneider
10 years, 4 months ago (2010-08-26 08:49:13 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698